feat(react-headless): expose token as client setting
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stigi
changed the title
token as client settingtoken as client setting
@magicbell/cli
@magicbell/core
@magicbell/embeddable
@magicbell/codegen
@magicbell/in-app
magicbell
@magicbell/magicbell-react
@magicbell/project-client
@magicbell/react-headless
@magicbell/user-client
@magicbell/webpush
commit: |
stigi
force-pushed
the
headless-token
branch
from
6efd36e to
e12c9a2
Compare
|
Not sure why the tests failed, but #464 shows the same failure. I ran |
smeijer
approved these changes
Feb 14, 2025
Merged
stigi
pushed a commit
that referenced
this pull request
Feb 14, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#459](#459) [`6688f1c`](6688f1c) Thanks [@MagicBella](https://github.com/MagicBella)! - Automatic minor version bump for changes in `magicbell`. ## @magicbell/[email protected] ### Minor Changes - [#459](#459) [`6688f1c`](6688f1c) Thanks [@MagicBella](https://github.com/MagicBella)! - Automatic minor version bump for changes in `@magicbell/project-client`. ## @magicbell/[email protected] ### Minor Changes - [#465](#465) [`748822c`](748822c) Thanks [@stigi](https://github.com/stigi)! - Added `token` as a way to authenticate the react-headless SDK. Also improved typings to make clear which combination of parameters are expected ### Patch Changes - Updated dependencies \[[`6688f1c`](6688f1c)]: - [email protected] ## @magicbell/[email protected] ### Minor Changes - [#459](#459) [`6688f1c`](6688f1c) Thanks [@MagicBella](https://github.com/MagicBella)! - Automatic minor version bump for changes in `@magicbell/user-client`. ## @magicbell/[email protected] ### Patch Changes - Updated dependencies \[[`6688f1c`](6688f1c)]: - [email protected] ## @magicbell/[email protected] ### Patch Changes - Updated dependencies \[]: - @magicbell/[email protected] ## @magicbell/[email protected] ### Patch Changes - Updated dependencies \[[`6688f1c`](6688f1c)]: - @magicbell/[email protected] ## @magicbell/[email protected] ### Patch Changes - Updated dependencies \[[`748822c`](748822c)]: - @magicbell/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v1 user client supports token auth (code), but that was not available in react-headless (code).
This PR allows to pass the
tokenthrough theMagicBellProvideto theUserClientwhere it was already accepted.I've tested this in magicbell/mobile-inbox#21 where I used the preview package and can confirm that notifications load successfully when using a v2 JWT token.