Fix access of Spree namespaces #13
Conversation
mayankdedhia
changed the title
| @orders = @search.result | ||
|
|
||
| supplier_earnings_map = @orders.map(&:supplier_earnings_map) | ||
| grouped_suppliers_map = supplier_earnings_map.flatten.group_by(&:name).values | ||
| grouped_suppliers_map = supplier_earnings_map.flatten.group_by { |s| s[:name] }.values |
There was a problem hiding this comment.
here in case that the suppliers aren't present, maybe we should use:
supplier_earnings_map.flatten.group_by { |s| s[:name] }&.values
There was a problem hiding this comment.
Let me test that first and then change it
| get :earnings | ||
| post :earnings | ||
| get :earnings | ||
| post :earnings |
There was a problem hiding this comment.
Interesting, is the current report sending the form as a post request? this should be GET so it can be bookmarkable
| @@ -1,6 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require 'csv' | |||
| require "csv" | |||
There was a problem hiding this comment.
we try to use double quotes only whenever we need to interpolate variables, leaving the rest as single quotes
There was a problem hiding this comment.
That is my editor playing with me
| def supplier_total_sales | ||
| params[:q] = search_params | ||
|
|
||
| @search = ::Spree::Order.complete.not_canceled.ransack(params[:q]) |
There was a problem hiding this comment.
is there any default params? like only last 30 days, I can see some performance degradation over time with more and more data being computed
There was a problem hiding this comment.
Makes sense to add a range, will update that
| def supplier_total(user_or_supplier) | ||
| def supplier_total_sales(user_or_supplier) | ||
| supplier = user_or_supplier.is_a?(::Spree::Supplier) ? user_or_supplier : user_or_supplier.supplier | ||
| shipments = self.shipments.by_supplier(supplier) |
| suppliers.map do |s| | ||
| { | ||
| name: s.name, | ||
| total_sales: self.supplier_total_sales(s), |
|
|
||
| context 'when passed a supplier' do | ||
| it 'returns the total commission earned for the order for a given supplier' do | ||
| context "when passed a supplier" do |
There was a problem hiding this comment.
Same here as @softr8 has recommended, I would suggest to keep the single quotes
Add a fix to access the Spree namespace