fix(spoolman): save spool id in lowercase variable #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with saving spool IDs for individual tools on a multi-tool instance. Currently, no updates are written to the variables file and an error is shown when selcting a new spool for any toolhead. The cause appears to be that upper case letters (which the current implementation uses) are not allowed. See the Klipper docs.
This PR simply changes the variable name to lower case, resolving the problem.
Running Klipper v0.12.0-451, Moonraker v0.9.3-65
Related Tickets & Documents
n/a
Mobile & Desktop Screenshots/Recordings
Console output displaying the error message:
[optional] Are there any post-deployment tasks we need to perform?
n/a
Signed-off-by: Paul Gendolla [email protected]