Done a lot but no tests #1369
Open
Done a lot but no tests #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder, and other small changes
|
It would be very helpful to leave a description of how the databases were set up, with the tables and columns etc (for example leaving the exact SQL messages), so that it's easy to run this on another computer. Also in your README (or the index page?) you could direct us to the urls where we can find your functionality - i.e. |
|
Two more recommendations: try to get in the habit of committing more often, with messages that specifically tell people what you changed (e.g. 'add peep view erb'). And the second, you can probably guess - installing test-driving as a habit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got really carried away with myself, the code engulfed me, every functionality about the web app works though :) (I think lol)