initial PR #1385
Open
initial PR #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easy to read code and good test coverage. Easy to follow naming conventions. Nice work :) |
|
Nice commit messages - clear and informative. The tests look good, but I can't run them because I can't replicate your database setup. That means I can only see your index page - which, I admit, does look slick. My main criticism would be that there's no way to work out your database set up. I can see from your test that your messages table has three columns, and the first two of them are numbers, but it's unclear what those numbers represent. If you include a migrations file, you can then ensure your project is reproducible on another machine - and you can even set up a rake task to take care of it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.