Week 4 Weekend challenge #1721
Open
Week 4 Weekend challenge #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandyMax974
reviewed
Mar 1, 2021
Comment on lines
+12
to
+16
| get '/peeps' do | ||
| @user = User.find(session[:user_id]) | ||
| @peeps = Peep.all | ||
| erb :'peeps/index' | ||
| end |
There was a problem hiding this comment.
I think your route has been kept skinny, very clean and easy to follow the flow of requests. One question on RESTful route, could you have used parameters in some of the routes?
sandyMax974
reviewed
Mar 1, 2021
Comment on lines
+1
to
+14
| default: &default | ||
| adapter: postgresql | ||
| encoding: unicode | ||
| pool: <%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %> | ||
|
|
||
| development: | ||
| <<: *default | ||
| database: peep_manager | ||
|
|
||
| production: | ||
| <<: *default | ||
| database: peepmanager | ||
| username: myapp | ||
| password: <%= ENV['MYAPP_DATABASE_PASSWORD'] %> |
There was a problem hiding this comment.
Nice one! you really took the time to work on the travis file!
sandyMax974
reviewed
Mar 1, 2021
Comment on lines
+1
to
+11
| require 'pg' | ||
|
|
||
| class DatabaseConnection | ||
| def self.setup(dbname) | ||
| @connection = PG.connect(dbname: dbname) | ||
| end | ||
|
|
||
| def self.query(sql) | ||
| @connection.exec(sql) | ||
| end | ||
| end |
There was a problem hiding this comment.
Great user of SRP, having a DatabaseConnection class makes the files cleaner - 100%!
sandyMax974
reviewed
Mar 1, 2021
Comment on lines
+4
to
+14
| class Peep | ||
| def self.create(content:, user:) | ||
| time = Time.now.strftime('%T') | ||
| result = DatabaseConnection.query("INSERT INTO peeps (content, user_id, time_created) VALUES ($$#{content}$$, #{user.id}, '#{time}') RETURNING id, content, time_created;") | ||
| Peep.new( | ||
| id: result[0]['id'], | ||
| content: result[0]['content'], | ||
| time: result[0]['time_created'], | ||
| user: user | ||
| ) | ||
| end |
There was a problem hiding this comment.
Having the database class allows you to keep your other classes net
sandyMax974
reviewed
Mar 1, 2021
Comment on lines
+4
to
+6
| class User | ||
| def self.create(email:, password:, name:, username:) | ||
| encrypted_password = BCrypt::Password.create(password) |
|
Great use of SRP, encapsulation, MVC and keeping a skinny controller. Very impressive used of the new technologies like Travis or the BCrypt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can sign up, log in, log out. Posting a peep is only possible when authenticated as a user. Most user stories completed except for the last one (sending an email when tagged in a 'peep'). Also didn't implement replies functionality. Minimal css was also used. Probably could have done better in making the controller neater and need to make unit tests more isolated as some (Peep class) were dependent on the User class.