Chitter-Challenge #1722
Open
Chitter-Challenge #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really good. I like the design of the web pages and overall the code is easy to follow and well-written. I'm not sure how much useful feedback I can give, to be honest, as I didn't get to adding users and I'm not sure I understand half of the code without studying it for a while. I'll see if I can add some specific comments shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete
Covers most user stories
Looks quite nice
Added additional features such as search by hashtag and user
Unfinished
Does not email user when tagged in a post
Testing is not complete
Refactor
To Improve
Add edit and delete buttons