Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chitter challenge #1728

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Chitter challenge #1728

wants to merge 12 commits into from

Conversation

olgachmaj
Copy link

No description provided.

olga and others added 12 commits February 26, 2021 15:37
Completed project set up and wrote adding_peep_to_feed feature test.
22dd848
Passed minimal unit test for .add and .all method for class Peep. Cre…
6f3241e 
…ated new routes,erb files and database_helper.
Passed adding and displating a peep feature tests, fixed bugs in Peep…
d143852 
….rb, created web_helper.
Added a feature allowing peeps to be displayed in reverse chronologic…
ac65347 
…al order.
Added timestamp to each new peep
b05ae96
Added feature allowing to register new user at route /users/new. Adde…
3377e68 
…d feature and unit tests. Drafted tests for find method allowing to find user.id through the sinatra session
Fully implemented .create and .find methods in User. User is being gr…
f30b213 
…eeted with its email on root.
Allows user to sign in if they provide valid email and password, does…
9f4fa39 
… not allow to sign in if provided email is not in the data base. Updated tests. Displays an alert if sign in fails.
Added password encryption on sign up
f09eb4e
Tested and implemented a feature not allowing a sign in with invalid …
01b75d5 
…password.
Tested and implemented feature allowing user to sign out. After signi…
5ca9517 
…ng out displaying a notice at route root.
@olgachmaj
Update README.md
489f0f0
@ianmcnicholas
Copy link

ianmcnicholas commented Mar 1, 2021 •
edited
Loading

Good number of commits with detail to them
Pull request should have some comments with it.
Readme could do with being slightly more detailed - e.g. how to run the program etc.
Forms appear to have the submit button before the text input, is this deliberate?
Lots of tests! Great to see
RSpec currently has a failing test
Have you used rubocop?
Is the view of peeps ordered by timestamp or by peep id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgachmaj @ianmcnicholas