chitter-challenge #2086
Open
chitter-challenge #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the repository classes the find and all methods for posts and users are quite long, perhaps part of it could be put into a private method to reduce the size of method. |
|
All tests passed except for 2 in post_repository_spec, it expected create_at to equal a timezone of +08 but was receiving +01. I think this problem comes in during seeding the tables, the date put in has no timezone specified, so maybe in my computer it’s defaulting to +1. |
|
Website works when using rackup. Good use of checking for invalid input. |
|
Could maybe add tests in app_spec that check when a new post is added it can be found on the home page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.