-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules for detecting donut-related features #997
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Still34 - this looks great so far. Please see my comments and open a PR at https://github.com/mandiant/capa-testfiles for the test file(s) referenced in these rules so we can get the lints passing.
data-manipulation/encryption/chaskey/encrypt-data-using-chaskey.yml
Outdated
Show resolved
Hide resolved
data-manipulation/encryption/speck/encrypt-data-using-speck.yml
Outdated
Show resolved
Hide resolved
I've been busy with other stuff this week and possibly for the next few days as well. I'll come back and address the comments before the month ends. Thanks! |
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tightened down the donut rule, and as for the basic block ones, I'm not entirely sure how I'd go about rewriting the rules to tighten the scope.
Signed-off-by: Still Hsu <[email protected]>
What about |
Summary
Notes
Sample
https://bazaar.abuse.ch/sample/d890c1c67d83f1131c065b5eb5f263cbf54559dbcdb4562c3bde3dc30d1a3205/