Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #34 #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #34 #46

wants to merge 1 commit into from

Conversation

codesardine
Copy link

No description provided.

@romangg
Copy link
Member

romangg commented Sep 23, 2024

Thanks. Can you give some more info? Why png instead of webp? Does it have better compatibility with shadows?

Add this info also to the commit message and use conventional commit format so the pipeline passes.

@codesardine
Copy link
Author

Thanks. Can you give some more info? Why png instead of webp? Does it have better compatibility with shadows?

Add this info also to the commit message and use conventional commit format so the pipeline passes.

The image format that does matter too mutch as long as it is small the new image does not have a background so when we apply the drop-shadow the shadows only go on the image and not the square cube behind it, both webp or png have support for alpha channel.

@romangg
Copy link
Member

romangg commented Sep 24, 2024

The outline of the llama looks pixelated here in dark mode. But I think removing the squares looks better.

The drop shadow on the top image makes the graphic less appealing. Remove it from there please.

@codesardine
Copy link
Author

codesardine commented Sep 24, 2024

The outline of the llama looks pixelated here in dark mode. But I think removing the squares looks better.

The drop shadow on the top image makes the graphic less appealing. Remove it from there please.

In what browser? here vivaldi and firefox show a good image.
did you try and disable hardware acceleration, could be a issue on your local machine, you were also not able to visualize the box shadow on your end. Also you have to decide if you want shadow or not, it has to be consistent shadows on none of the images or shadows in all images.
Screenshot from 2024-09-24 20-37-48

Add shadows to all images in the page equaly
remove  backgrounds from  ollama logo
replace box shadow with drop-shadow
fix ollama in dark theme

delete png

add larger outline on ollama

remove shadow from services
@romangg
Copy link
Member

romangg commented Sep 30, 2024

The issue might be due to my hidpi screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants