Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set multiselect to false in EnumeratedStringProperty #38372

Merged

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Nov 7, 2024

By setting isMultipleSelectionAllowed() to always return true, the correct GUI widget is displayed. cppcheck pointed out that this is the implementation in the parent and requested that I remove the useless override. Also, remove as many imports as possible with the code still compiling and operating.

This is a follow on to #38360. There is still a remaining issue with how the property type is rendered in the user docs.

There is no associated issue, but it is associated with EWM7925

Further detail of work

To test:

  1. Start mantidworkbench
  2. Open the dialog for Rebin
  3. See that it renders how it used to

This does not require release notes because it fixes an issue introduced during the development cycle.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework labels Nov 7, 2024
This is the way it should be used. Also remove as many imports as
possible with the code still compiling and operating.
@peterfpeterson peterfpeterson marked this pull request as ready for review November 8, 2024 13:41
@peterfpeterson peterfpeterson added this to the Release 6.12 milestone Nov 8, 2024
@rboston628
Copy link
Contributor

Dropdown works in Rebin
image

Dropdown works in CalculateDIFC
image

Dropdown works in AddSampleLog
image

@SilkeSchomann SilkeSchomann self-assigned this Nov 11, 2024
@SilkeSchomann SilkeSchomann merged commit f6559b1 into mantidproject:main Nov 11, 2024
10 checks passed
@peterfpeterson peterfpeterson deleted the enumerated_string_gui branch November 11, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants