Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build PyInstaller on github actions #1687

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

DolicaAkelloEgwel
Copy link
Collaborator

@DolicaAkelloEgwel DolicaAkelloEgwel commented Feb 1, 2023

Issue

Closes #1683

Description

Creates an action for a PyInstaller build.

Acceptance Criteria

Check that the output shows an exe has been created. Download the artifact from here: https://github.com/mantidproject/mantidimaging/actions/runs/4073870818

Documentation

Updated release notes.

@DolicaAkelloEgwel DolicaAkelloEgwel changed the title windows action 1683: Single file PyInstaller action Feb 1, 2023
@coveralls
Copy link

coveralls commented Feb 1, 2023

Coverage Status

Coverage: 77.115%. Remained the same when pulling a690549 on 1683-single-file-pyinstaller-action into 69b8ea3 on main.

@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review February 2, 2023 12:26
@samtygier-stfc
Copy link
Collaborator

Looks good. I can download the MantidImaging.zip https://github.com/mantidproject/mantidimaging/actions/runs/4073870818

Lets also see if we can get this working to attach that file to a release/tag. So that it can be public.

I think https://github.com/softprops/action-gh-release is the right tool to use. We probably want draft and prerelease set true, and tag_name to nightly. Once it works we can tweak when it actually runs.

@JackEAllen JackEAllen changed the title 1683: Single file PyInstaller action Build PyInstaller on github actions May 22, 2023
@samtygier-stfc
Copy link
Collaborator

This is held up because the packages built on github actions do not have functioning CUDA.

@MikeSullivan7 MikeSullivan7 self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build PyInstaller on Github Actions
4 participants