Fix for empty mdhisto lines #987
Conversation
There was a problem hiding this comment.
Did a functional test following the test instructions.
Mantid doesn't crash, and there's no extra blank line on the mdhisto cuts.
I would be happy to approve, just want to ask if it needs release note?
Additionally: if you delete all or any line on MDhisto cuts, and the plot window of those lines is still open, it can lead to a crash when trying to modify the intensity again. It is not what this pr is trying to solve, but it would be nice to make part of a separate issue.
|
@adriazalvarez The release notes for MSlice are added when the SHA for MSlice is updated in Mantid. The release note infrastructure in Mantid cannot pick up release notes from the MSlice repo easily. I have opened a GitHub issue for the problem after deleting a workspace: #988 |
|
Ah, I see. 😅 Thanks for letting me know. |
Description of work:
When the intensity of a cut is changed to GDOS, a two-dimensional MDHisto workspace is created. When converting this to a matrix workspace, the bin size needs to be calculated on base of the second dimension, not the first. I have also added an error message in case a one-dimensional workspace or the second dimension does not have the correct size. This check is now also covered by a unit test.
To test:
Follow the instructions in the original issue: #986
In addition, please also check that the following problem does not re-occur: #972
Fixes #986.