Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Various Fixes #1

wants to merge 7 commits into from

Conversation

smx-smx
Copy link

@smx-smx smx-smx commented Sep 21, 2024

  • Fixed devserver launch (task wasn't being awaited, so it never ran)
  • Fixed devserver launch command ("cmd /C" instead of "/K", add missing space). Working Directory was incorrect too (added heuristic to determine the project root directory, assuming we're started from the "bin" folder)
  • Kill devserver on application stop
  • Use an event for waiting, instead of polling
  • Update dependencies (both C# and Svelte)
  • Update to .NET 8 and Svelte 4
  • Use Console subsystem instead of Windows to view debug logs
  • Add Project Solution file

The task wasn't being awaited, so it never ran
I also updated dependencies for both C# and JS
this sends CTRL-C to the cmd window
fixes sporadic exit code 1 when running npm
@manuel3108
Copy link
Owner

Hey! Thanks for your improvements, all of them totally make sense, and I actually forgot I had created this repository.

As far as I'm aware most of the dev server has now been converted into the official project:

Though I'm currently unable to find any official examples or documentation about this. Neither on the website nor in their repositories. Maybe @Denny09310 can give a small heads up on the status here, as I have not been following photino that closely over the last few months. Have those changes been released? Is there any documentation on how to use the official dev server?

Or am I missing something? For me it looks like only some dotnet improvements have been merged and I was unable to find any other related PR.

Whatever is the case with the above discussion I would suggest taking a look at the changes @Denny09310 as he has put tons of thoughts into it and prepared a really robust implementation

@Denny09310
Copy link

Denny09310 commented Sep 23, 2024

Hi @manuel3108 thanks for the mentioning. I totally forgot about the DevServer, there was a problem with the namespacing in this Photino.Server Issue. Now that you've remember it to me, I'll fix the only thing that remains, change the ProjectImport to a PackageImport to the latest Photino.NET package. It should be an easy fix, hopefully they'll merge quickly. For an example I could update my repository to the latest modifications so you can see how to setup the Server 😁

@manuel3108
Copy link
Owner

Hi @manuel3108 thanks for the mentioning. I totally forgot about the DevServer, there was a problem with the namespacing in this Photino.Server Issue. Now that you've remember it to me, I'll fix the only thing that remains, change the ProjectImport to a PackageImport to the latest Photino.NET package. It should be an easy fix, hopefully they'll merge quickly. For an example I could update my repository to the latest modifications so you can see how to setup the Server 😁

That would be awesome!

@Denny09310
Copy link

Denny09310 commented Sep 23, 2024

Changes made, now we have only to wait for the review of the owner to be merged. @smx-smx if you want to look at the sample please check the debug branch. It has the references for the non-published projects (Photino.NET.Server, Photino.NET.IPC), but you can get an idea of how to setup the project once they have been released. In the meantime you can download the other repos and place them side-by-side to try the sample. It's in react but the user interface can be swapped easily, replace the content of the Interface folder with your project and the server options. Tomorrow I'll try to write down some detailed instructions in the readme 😁😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants