Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

Commit

Permalink
Get rid of hosted zones and acceleration
Browse files Browse the repository at this point in the history
  • Loading branch information
Manuel Valls Fernández committed Sep 19, 2020
1 parent 8125945 commit b4343c3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 64 deletions.
4 changes: 0 additions & 4 deletions aws/data_source_aws_s3_bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ func dataSourceAwsS3Bucket() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"hosted_zone_id": {
Type: schema.TypeString,
Computed: true,
},
"region": {
Type: schema.TypeString,
Computed: true,
Expand Down
60 changes: 0 additions & 60 deletions aws/resource_aws_s3_bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,6 @@ func resourceAwsS3Bucket() *schema.Resource {
},
},

"hosted_zone_id": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"region": {
Type: schema.TypeString,
Computed: true,
Expand Down Expand Up @@ -328,16 +322,6 @@ func resourceAwsS3Bucket() *schema.Resource {
Default: false,
},

"acceleration_status": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{
s3.BucketAccelerateStatusEnabled,
s3.BucketAccelerateStatusSuspended,
}, false),
},

"request_payer": {
Type: schema.TypeString,
Optional: true,
Expand Down Expand Up @@ -464,12 +448,6 @@ func resourceAwsS3BucketUpdate(d *schema.ResourceData, meta interface{}) error {
}
}

if d.HasChange("acceleration_status") {
if err := resourceAwsS3BucketAccelerationUpdate(s3conn, d); err != nil {
return err
}
}

if d.HasChange("request_payer") {
if err := resourceAwsS3BucketRequestPayerUpdate(s3conn, d); err != nil {
return err
Expand Down Expand Up @@ -637,22 +615,6 @@ func resourceAwsS3BucketRead(d *schema.ResourceData, meta interface{}) error {
return fmt.Errorf("error setting versioning: %s", err)
}

// Read the acceleration status

accelerateResponse, err := retryOnAwsCode(s3.ErrCodeNoSuchBucket, func() (interface{}, error) {
return s3conn.GetBucketAccelerateConfiguration(&s3.GetBucketAccelerateConfigurationInput{
Bucket: aws.String(d.Id()),
})
})

// Amazon S3 Transfer Acceleration might not be supported in the region
if err != nil && !isAWSErr(err, "MethodNotAllowed", "") && !isAWSErr(err, "UnsupportedArgument", "") {
return fmt.Errorf("error getting S3 Bucket acceleration configuration: %s", err)
}
if accelerate, ok := accelerateResponse.(*s3.GetBucketAccelerateConfigurationOutput); ok {
d.Set("acceleration_status", accelerate.Status)
}

// Read the request payer configuration.

payerResponse, err := retryOnAwsCode(s3.ErrCodeNoSuchBucket, func() (interface{}, error) {
Expand Down Expand Up @@ -1202,28 +1164,6 @@ func resourceAwsS3BucketLoggingUpdate(s3conn *s3.S3, d *schema.ResourceData) err
return nil
}

func resourceAwsS3BucketAccelerationUpdate(s3conn *s3.S3, d *schema.ResourceData) error {
bucket := d.Get("bucket").(string)
enableAcceleration := d.Get("acceleration_status").(string)

i := &s3.PutBucketAccelerateConfigurationInput{
Bucket: aws.String(bucket),
AccelerateConfiguration: &s3.AccelerateConfiguration{
Status: aws.String(enableAcceleration),
},
}
log.Printf("[DEBUG] S3 put bucket acceleration: %#v", i)

_, err := retryOnAwsCode(s3.ErrCodeNoSuchBucket, func() (interface{}, error) {
return s3conn.PutBucketAccelerateConfiguration(i)
})
if err != nil {
return fmt.Errorf("Error putting S3 acceleration: %s", err)
}

return nil
}

func resourceAwsS3BucketRequestPayerUpdate(s3conn *s3.S3, d *schema.ResourceData) error {
bucket := d.Get("bucket").(string)
payer := d.Get("request_payer").(string)
Expand Down

0 comments on commit b4343c3

Please sign in to comment.