Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[Mappy] correct insets camera management - see https://github.com/map… #16061

Closed
wants to merge 1 commit into from

Conversation

RomainQuidet
Copy link
Contributor

Everything is described in the iOS branch issue mapbox/mapbox-gl-native-ios#59

Copy link
Contributor

@astojilj astojilj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.
Looks good.
Our map.test.cpp tests are very permissive and don't cover all the paths. I'll git am your patch to a separate PR with additional unit tests and submit to review.

@RomainQuidet
Copy link
Contributor Author

Great thanks !

Copy link
Contributor

@astojilj astojilj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be submitted via #16067.
@RomainQuidet Thanks!

@astojilj astojilj closed this Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants