Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify jazzy finds USRs on CI #2078

Closed
1ec5 opened this issue Apr 4, 2019 · 3 comments · Fixed by #3439
Closed

Verify jazzy finds USRs on CI #2078

1ec5 opened this issue Apr 4, 2019 · 3 comments · Fixed by #3439
Assignees
@chezzdev
Labels
build Issues related to builds and dependency management. documentation topic: documentation
Milestone
v2.1-beta

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 4, 2019

To prevent #1795 from regressing a third time or less widespread USR issues from cropping up on individual symbols, we should add a step to the CircleCI configuration that runs jazzy and looks for any USR in a generated HTML file. Even better, we could parse jazzy’s output to look for USR warnings and fix the few that remain.

/cc @mapbox/navigation-ios
@1ec5 1ec5 added topic: documentation build Issues related to builds and dependency management. - tests documentation labels Apr 4, 2019
This was referenced Apr 4, 2019
Merged
Closed
@1ec5 1ec5 mentioned this issue Jan 15, 2020
Closed
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 15, 2020

It happened again: #2312.

@1ec5 1ec5 mentioned this issue Apr 6, 2021
Merged
@jill-cardamon jill-cardamon mentioned this issue Apr 16, 2021
Merged
@1ec5 1ec5 mentioned this issue Jul 16, 2021
Closed
@truburt truburt removed the - tests label Sep 29, 2021
@S2Ler
Copy link
Contributor

S2Ler commented Sep 30, 2021

Shall we prioritize this? @truburt @1ec5

@1ec5 1ec5 added this to the v2.1 (beta) milestone Sep 30, 2021
@chezzdev
Copy link
Contributor

chezzdev commented Oct 4, 2021

I'm working on generating docs on CI, so I'll integrate warning checks in that scope.

@chezzdev chezzdev self-assigned this Oct 4, 2021
@chezzdev chezzdev mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chezzdev chezzdev

Labels
build Issues related to builds and dependency management. documentation topic: documentation
Projects
None yet
Milestone
v2.1-beta
Development

Successfully merging a pull request may close this issue.

Docs generation automation mapbox/mapbox-navigation-ios
4 participants
@S2Ler @1ec5 @chezzdev @truburt