Implement support for CPTemplateApplicationSceneDelegate UIScene-based CarPlay on iOS 13 and above #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The initial version of the PR adds the Nav SDK support. I'm putting it up as a draft PR to get comments before doing all the work to convert the Example app to use UIScene templates for CarPlay. |
|
Added UIScene and CPTemplateApplicationSceneDelegate support to the Example app for iOS 13 and above. Allows us to use newer iOS 13 CarPlay SDK. |
1ec5
reviewed
Feb 27, 2021
1ec5
added
feature
1ec5
modified the milestones:
duck (android-v1.4.0 / ios-v1.2.0),
e (android-v1.5.0 / ios-v1.3.0)
avi-c
force-pushed
the
ac-CarPlayUISceneSupport
branch
from
1123295 to
4632205
Compare
1ec5
modified the milestones:
e (android-v1.5.0 / ios-v1.3.0),
f (android-v1.6.0 / ios-v1.4.0)
1ec5
approved these changes
Apr 6, 2021
| @@ -901,7 +901,7 @@ | |||
| C53C19751F38EADE008DB406 /* fr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fr; path = fr.lproj/Localizable.strings; sourceTree = "<group>"; }; | |||
| C53C19771F38EAE4008DB406 /* ca */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.strings; name = ca; path = ca.lproj/Localizable.strings; sourceTree = "<group>"; }; | |||
| C53C197A1F38EAEA008DB406 /* Base */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = Base; path = Base.lproj/Localizable.strings; sourceTree = "<group>"; }; | |||
| C53F2F0720EBC95600D9798F /* Example-CarPlay.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "Example-CarPlay.app"; sourceTree = BUILT_PRODUCTS_DIR; }; | |||
| C53F2F0720EBC95600D9798F /* Example.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Example.app; sourceTree = BUILT_PRODUCTS_DIR; }; | |||
There was a problem hiding this comment.
By the way, this means it isn’t possible to install the normal Example and CarPlay-enabled Example applications simultaneously on a single device or simulator. Not a huge deal, but it may be surprising at first.
| /** | ||
| CarPlay support requires iOS 12.0 or above and the CarPlay framework. | ||
| */ | ||
| public class CarPlayManager: NSObject { |
There was a problem hiding this comment.
Finally, jazzy will stop warning about missing USRs for these conditionally compiled symbols. 😌
/ref #2078
…ors for iOS 12 CarPlay UI.
…mple app for iOS 13 and above.
….swift file. Change target name for CarPlay app to Example_CarPlay so UIScene manifest entry in Info.plist can find the AppDelegate class name for both app targets.
avi-c
force-pushed
the
ac-CarPlayUISceneSupport
branch
from
008d3a5 to
7c35d5d
Compare
|
Made the change to the CHANGELOG entry as requested and rebased to |
avi-c
added a commit
that referenced
this pull request
May 9, 2021
…d CarPlay on iOS 13 and above (#2832) * Add support for UIScene-based CarPlay API.
avi-c
added a commit
that referenced
this pull request
May 15, 2021
…d CarPlay on iOS 13 and above (#2832) * Add support for UIScene-based CarPlay API.
avi-c
added a commit
that referenced
this pull request
May 27, 2021
…d CarPlay on iOS 13 and above (#2832) * Add support for UIScene-based CarPlay API.
avi-c
added a commit
that referenced
this pull request
Jun 15, 2021
…d CarPlay on iOS 13 and above (#2832) * Add support for UIScene-based CarPlay API.
avi-c
added a commit
that referenced
this pull request
Jul 14, 2021
…d CarPlay on iOS 13 and above (#2832) * Add support for UIScene-based CarPlay API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In iOS 13 Apple added a Template-based mechanism for providing CarPlay support to apps. The Nav SDK needs to include support for these newer APIs while ensuring we don't break the earlier iOS 12 CarPlay delegate pattern until we drop support for iOS 12.
Fixes #2260
Implementation
The changes required within the Nav SDK are fairly minimal, mainly adding conformance to the CPTemplateApplicationSceneDelegate protocol. More extensive changes are needed to the Example app in order to adopt UIScene support.