Remove Objective-C compatibility; adopt Swift language features by JThramer · Pull Request #2230 · mapbox/mapbox-navigation-ios

Commits on Oct 15, 2019

WIP: Starting out with a blanket wipe of @objc . 90 build errors.

Jerrad Thramer
authored and
1ec5
committed
WIP: Refactoring. Single digit errors.

Jerrad Thramer
authored and
1ec5
committed
Fixing UnimplementedLogging protocol issues

Jerrad Thramer
authored and
1ec5
committed
Adding stubs for LegacyRouteController

Jerrad Thramer
authored and
1ec5
committed
Continuing to churn through this. 142 errors.

Jerrad Thramer
authored and
1ec5
committed
adding defaults for CarPlayManagerDelegate

Jerrad Thramer
authored and
1ec5
committed
Continuing to go fast. 84 remain.

Jerrad Thramer
authored and
1ec5
committed
Really whittling it down now. 9 errors remain.

Jerrad Thramer
authored and
1ec5
committed
Fixing extension issues, can't override from extensions in swift. 5 issues remain.

Jerrad Thramer
authored and
1ec5
committed
Moving to proper place in file

Jerrad Thramer
authored and
1ec5
committed
adding default handling for TopBannerViewControllerDelegate

Jerrad Thramer
authored and
1ec5
committed
Took care of all remaining issues on first-pass. Ready for second phase.

Jerrad Thramer
authored and
1ec5
committed
Removing OBJ-C example.

Jerrad Thramer
authored and
1ec5
committed
All build errors fixed. Kobe's Guidance cards are not working, and there are some issues with some other tests.

Jerrad Thramer
authored and
1ec5
committed
Fixing integration tests with Instruction Cards.

Jerrad Thramer
authored and
1ec5
committed
Fixing last remaining test failure.

Jerrad Thramer
authored and
1ec5
committed
Apparently CI doesn't like the unified logging module. Lets see if we can fix this by important the equivalent os.log

Jerrad Thramer
authored and
1ec5
committed
Fixing UserCourseView and some other issues that were causing the CI bot to fail.

Jerrad Thramer
authored and
1ec5
committed
Removing Orphaned class.

Jerrad Thramer
authored and
1ec5
committed
Fixing a warning that CI is complaining about

Jerrad Thramer
authored and
1ec5
committed
Replacing janky delegateIdentifier property (supposed to tell you what protocol you are not implementing) with method argument that does a much better job at capturing what we want.

Jerrad Thramer
authored and
1ec5
committed
Removing mention of OBJ-C from documentation. Also adding cover.md to project

Jerrad Thramer
authored and
1ec5
committed
Replacing all OBJ-C constants and enumerations with swift patterns.

Jerrad Thramer
authored and
1ec5
committed
Fixing lingering issues.

Jerrad Thramer
authored and
1ec5
committed
Fixed default protocol method implementation visibility
1ec5
committed
Getting rid of Self. in type extensions, which only works in swift 5.1

Jerrad Thramer
authored and
Jerrad Thramer
committed

Commits on Oct 16, 2019

Commits on Oct 18, 2019

Restored user course view to map view
1ec5
committed

Commits on Oct 28, 2019

Testing CI Build Failure

Jerrad Thramer
authored and
Jerrad Thramer
committed

Commits on Nov 1, 2019

PR Comments

Jerrad Thramer
authored and
Jerrad Thramer
committed
PR comment: documentation for notification user info keys

Jerrad Thramer
authored and
Jerrad Thramer
committed
PR Comment: Adding note about unimplemented feature

Jerrad Thramer
authored and
Jerrad Thramer
committed
Updating with better copy

Jerrad Thramer
authored and
Jerrad Thramer
committed
WIP: adding proper swift error for voice/speech issues

Jerrad Thramer
authored and
Jerrad Thramer
committed

Commits on Nov 4, 2019

Implementing swift speech errors

Jerrad Thramer
authored and
Jerrad Thramer
committed
There actually aren't any unknown speech errors.

Jerrad Thramer
authored and
Jerrad Thramer
committed

Commits on Nov 5, 2019

Adding documentation and changelog entries

Jerrad Thramer
authored and
Jerrad Thramer
committed
whoopsie

Jerrad Thramer
authored and
Jerrad Thramer
committed
Fixing testDefaultUserInterfaceUsage test

Jerrad Thramer
authored and
Jerrad Thramer
committed

Commits on Nov 8, 2019

Adding interface deprecations

Jerrad Thramer
authored and
Jerrad Thramer
committed
Adding testing for UnimplementedLogging that _hopefully_ should satisfy codecov.

Jerrad Thramer
authored and
Jerrad Thramer
committed
Final changelog and documentation entries.

Jerrad Thramer
authored and
Jerrad Thramer
committed
Taking minh's suggestion to make userDistanceToManeuverLocation initialize to correct value.

Jerrad Thramer
authored and
Jerrad Thramer
committed
Doh!

Jerrad Thramer
authored and
Jerrad Thramer
committed

Commits on Nov 12, 2019

Commits on Nov 13, 2019

Commits on Nov 19, 2019

Wrapping up final outstanding issues.

Jerrad Thramer
authored and
Jerrad Thramer
committed
Merge branch 'master' into jerrad/objc-delenda-est

Jerrad Thramer
authored and
Jerrad Thramer
committed
Other PR suggestions

Jerrad Thramer
authored and
Jerrad Thramer
committed

Commits on Nov 20, 2019

Updating test to reflect new uniquing mechanism on UnimplmenetedLogging.

Jerrad Thramer
authored and
Jerrad Thramer
committed
Fixing indendation issue.

Jerrad Thramer
authored and
Jerrad Thramer
committed
PR Suggestion: Replace engine with synthesizer

Jerrad Thramer
authored and
Jerrad Thramer
committed