Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up RouteController user info keys #2290

Merged
merged 4 commits into from
Dec 27, 2019
Merged

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Dec 20, 2019

#2230 left some references to Objective-C symbols in documentation comments. This PR updates the references to the corresponding Swift symbols. It also renames RouteControllerNotificationUserInfoKey to RouteController.NotificationUserInfoKey.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added this to the v1.0.0 milestone Dec 20, 2019
@1ec5 1ec5 requested a review from JThramer December 20, 2019 21:41
@1ec5 1ec5 self-assigned this Dec 20, 2019
@1ec5 1ec5 changed the title Update Objective-C symbol references in comments Clean up RouteController user info keys Dec 21, 2019
@1ec5 1ec5 merged commit 3010193 into master Dec 27, 2019
@1ec5 1ec5 deleted the 1ec5-deobjc-comment-ref branch December 27, 2019 01:15
@1ec5 1ec5 modified the milestones: v1.0.0, v0.x next Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant