Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require map SDK v5.5.0 in v0.37.x #2301

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Require map SDK v5.5.0 in v0.37.x #2301

merged 1 commit into from
Jan 9, 2020

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jan 8, 2020

This change disallows versions of the map SDK beyond v5.5.x. It targets the v0.37.x release series.

/ref #2299
/cc @mapbox/navigation-ios @mapbox/maps-ios

@1ec5 1ec5 added the build Issues related to builds and dependency management. label Jan 8, 2020
@1ec5 1ec5 added this to the v0.37.1 milestone Jan 8, 2020
@1ec5 1ec5 self-assigned this Jan 8, 2020
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 8, 2020

After this change is merged into the release-v0.37 branch, we’ll cherry-pick it into the release-v0.38 branch and release both v0.37.1 and v0.38.2.

@1ec5 1ec5 mentioned this pull request Jan 8, 2020
Merged
@1ec5 1ec5 force-pushed the 1ec5-map-v5.5.0 branch from e48405e to d0941f3 Compare January 8, 2020 08:21
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 9, 2020 •
edited
Loading

I’m baffled that the Xcode_10.2_iOS_12.2_CP_install bot is repeatedly failing to pod install --repo-update with something resembling CocoaPods/CocoaPods#2944, considering that Xcode_10.2_iOS_12.2_CP_update is able to pod update --repo-update just fine in the same environment.

@1ec5 1ec5 force-pushed the 1ec5-map-v5.5.0 branch from 32cea1c to eba4b80 Compare January 9, 2020 08:06
@1ec5 1ec5 merged commit eba4b80 into release-v0.37 Jan 9, 2020
@1ec5 1ec5 deleted the 1ec5-map-v5.5.0 branch January 9, 2020 08:34
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 9, 2020

The errors were caused by running pod update in the PodInstall folder using CocoaPods v1.8, whereas only v1.6.1 is installed in CircleCI’s Xcode 10.2.1 image.

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 9, 2020 •
edited
Loading

Cherry-picked into the release-v0.38 branch as dd311e5.

@1ec5 1ec5 mentioned this pull request Jan 22, 2020
Closed
1ec5
1ec5 commented Jan 22, 2020
View reviewed changes
Cartfile.resolved
@@ -1,4 +1,4 @@
binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "5.2.0"
binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "5.5.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I must’ve either hand-edited this file or run it while experimenting with an == operator in the Cartfile, but the tadpole operator would actually resolved to v5.6.1. Fixed in #2317.

@1ec5 1ec5 mentioned this pull request Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@1ec5 1ec5

Labels
build Issues related to builds and dependency management.
Projects
None yet
Milestone
v0.37.1
Development

Successfully merging this pull request may close these issues.
1 participant
@1ec5