Async-update feature branch merge #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`onTick` allows to get each replayed location with its index `onReplayLoopCompleted` allows to stop replay after all locations replayed. Prevent crashes if incoming locations array is empty.
- `NavigationService.updateRoute`, `RouteController.updateRoute` is no longer synchronous. This change is needed because NavNative implementation is asynchronous, and we need to know when this operation completes so that we can update local properties with a new route. Otherwise, we can end up in a situation when the SDK state doesn't match with the nav status callback received from NavNative. - `userIsOnRoute(_:status:)` incorrectly assumes that the invalid route state is an off-route event. The invalid route state is reported when there is no route set in a native navigator, that happens during passive navigation. - It is no longer possible to set `RouteController.routeProgress` property synchronously for the same reason as why `RouteController.updateRoute` is asynchronous. - `updateNavigator` incorrectly referenced old `routeProgress` in the parameters to NavNative's `setRoute` method. - `RouteProgress.legIndexHandler` removed as it is no longer needed. `RouteProgress.legIndex` should be updated only after NavNative status callback, otherwise they will be out-of-sync. `RouteController.advanceLegIndex` is the correct method to change legIndex, then it will be updated in `RouteProgress`. - `NavigationEventsManagerTestDoubles.flush` method was adjusted to work closer to real world. Without clearing enqueuedEvents, if flus is called two times, flushed events will contain two duplicates. - A lot of `RouteController` dependent tests are fixed, some restored.
S2Ler
force-pushed
the
feature/async-updates
branch
from
68000ce to
c88a42f
Compare
bamx23
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of already reviewed PRs: