Replace legacy image downloader with new actor-based implementation #4588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current image downloader is based on
NSOperationQueue
and has some bugs that I previously described in #4587. There is also a chance that these bugs caused memory corruption in some cases.Instead of supporting sophisticated logic in legacy
NSOperation
-based implementation, I replaced it with new async/await implementation. It works the same way in fewer lines of code and because it's an actor, the compiler guarantees thread safety.The only minor downside is that we can't use it on iOS 12, so I added another very simple implementation of the image downloader. It still caches responses but doesn't support reentrancy (meaning that 5 requests one after another will trigger 5 downloads), which is a trade-off we have to make.
TODO: