Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup command #200

Merged
merged 7 commits into from
Mar 2, 2024
Merged

Setup command #200

merged 7 commits into from
Mar 2, 2024

Conversation

maxwai
Copy link
Collaborator

@maxwai maxwai commented Feb 11, 2024

Implements #142

@maxwai maxwai added help wanted Extra attention is needed question Further information is requested WIP PR is WIP labels Feb 11, 2024
@maxwai maxwai added this to the SS23 milestone Feb 11, 2024
@maxwai maxwai self-assigned this Feb 11, 2024
@maxwai maxwai changed the base branch from main to dependency-update February 11, 2024 15:55
@maxwai
Copy link
Collaborator Author

maxwai commented Feb 11, 2024

@schitcrafter I made the first part of the setup (setting the ghost warning deadline). Can you please take a look as see if you maybe have a better idea? Right now I would should copy paste this code, changing what fields is changed, until I've set all fields. This solution, while it works, isn't pretty and maybe you have a better idea.

@maxwai maxwai linked an issue Feb 11, 2024 that may be closed by this pull request
Base automatically changed from dependency-update to main February 11, 2024 17:11
@maxwai maxwai added ready for review PR is ready for review and removed WIP PR is WIP labels Feb 18, 2024
@maxwai maxwai changed the title WIP: Setup command Setup command Feb 18, 2024
@maxwai
Copy link
Collaborator Author

maxwai commented Feb 18, 2024

setup_command.rs was manually tested to 100% line coverage

@maxwai maxwai marked this pull request as ready for review February 18, 2024 16:18
@maxwai maxwai removed help wanted Extra attention is needed question Further information is requested labels Feb 18, 2024
@maxwai maxwai merged commit 508892e into main Mar 2, 2024
3 checks passed
@maxwai maxwai deleted the setup-command branch March 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setup command
2 participants