Improve range-accuracy on value definition diagnostics #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Marco Roth <[email protected]>
marcoroth
force-pushed
the
add-diagnostic-for-value-range-only-on-invalid-type
branch
from
ef82cbc
to
82a3460
Compare
marcoroth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #248 and initial setup for adding suggestions / code actions for #213
Based on marcoroth/stimulus-parser#114 and marcoroth/stimulus-parser#117.
Display diagnostic only on the offending type value instead of the whole value object.
Before
After