Skip to content

Commit

Permalink
fix: clone record using write_attribute because attr acessors may be …
Browse files Browse the repository at this point in the history
…overloaded
  • Loading branch information
marcosgz committed Jul 12, 2024
1 parent 22fca2b commit f2e5b43
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
esse-active_record (0.3.3)
esse-active_record (0.3.4)
activerecord (>= 4.2, < 8)
esse (>= 0.3.0)

Expand Down
2 changes: 1 addition & 1 deletion ci/Gemfile.rails-5.2.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
esse-active_record (0.3.3)
esse-active_record (0.3.4)
activerecord (>= 4.2, < 8)
esse (>= 0.3.0)

Expand Down
2 changes: 1 addition & 1 deletion ci/Gemfile.rails-6.0.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
esse-active_record (0.3.3)
esse-active_record (0.3.4)
activerecord (>= 4.2, < 8)
esse (>= 0.3.0)

Expand Down
2 changes: 1 addition & 1 deletion ci/Gemfile.rails-6.1.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
esse-active_record (0.3.3)
esse-active_record (0.3.4)
activerecord (>= 4.2, < 8)
esse (>= 0.3.0)

Expand Down
2 changes: 1 addition & 1 deletion ci/Gemfile.rails-7.0.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
esse-active_record (0.3.3)
esse-active_record (0.3.4)
activerecord (>= 4.2, < 8)
esse (>= 0.3.0)

Expand Down
2 changes: 1 addition & 1 deletion ci/Gemfile.rails-7.1.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
esse-active_record (0.3.3)
esse-active_record (0.3.4)
activerecord (>= 4.2, < 8)
esse (>= 0.3.0)

Expand Down
7 changes: 5 additions & 2 deletions lib/esse/active_record/callbacks/indexing_on_update.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ def call(model)
update_document(document)
return true unless document.routing

prev_record = model.class.new(model.attributes.merge(model.previous_changes.transform_values(&:first))).tap(&:readonly!)
prev_document = repo.serialize(prev_record)
prev_record = model.class.new
model.attributes.merge(model.previous_changes.transform_values(&:first)).each do |key, value|
prev_record[key] = value
end
prev_document = repo.serialize(prev_record.tap(&:readonly!))

return true unless prev_document
return true if [prev_document.id, prev_document.routing].include?(nil)
Expand Down
2 changes: 1 addition & 1 deletion lib/esse/active_record/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Esse
module ActiveRecord
VERSION = '0.3.3'
VERSION = '0.3.4'
end
end

0 comments on commit f2e5b43

Please sign in to comment.