Smart update with :update index with lazy attributes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document itself may not include the lazy attributes, and by performing :index request all the updated done through the lazy update attribute actions will be lost. So updated the logic to attempt push document using :update api with a :index fallback in case doc does not exist yet. This behaviour can be overriten by passing with: :index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexes where
lazy_document_attributedoc attributes are defined, use the:updatemethod instead of:indexduring the after commit on update. It should avoid lose data. Note that if the document is not yet indexed, a second attempt using :index request will be done.