Skip to content

Commit

Permalink
feat: only use optimize reindex when the import is also true
Browse files Browse the repository at this point in the history
  • Loading branch information
marcosgz committed Jul 19, 2024
1 parent 6787a6e commit 4d4e9b8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/esse/index/indices.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def reset_index(suffix: index_suffix, optimize: true, import: true, reindex: fal
suffix ||= Esse.timestamp
suffix = Esse.timestamp while index_exist?(suffix: suffix)

if optimize
if optimize && import
definition = [settings_hash, mappings_hash].reduce(&:merge)
number_of_replicas = definition.dig(Esse::SETTING_ROOT_KEY, :index, :number_of_replicas)
refresh_interval = definition.dig(Esse::SETTING_ROOT_KEY, :index, :refresh_interval)
Expand All @@ -74,7 +74,7 @@ def reset_index(suffix: index_suffix, optimize: true, import: true, reindex: fal
# @TODO: Reindex using the reindex API
end

if optimize && number_of_replicas != new_number_of_replicas || refresh_interval != new_refresh_interval
if optimize && import && number_of_replicas != new_number_of_replicas || refresh_interval != new_refresh_interval
update_settings(suffix: suffix)
refresh(suffix: suffix)
end
Expand Down

0 comments on commit 4d4e9b8

Please sign in to comment.