Updates package build #198
Conversation
| @@ -83,6 +90,7 @@ android { | |||
| } | |||
|
|
|||
| packagingOptions { | |||
| doNotStrip resolveBuildType() == 'debug' ? "**/**/*.so" : '' | |||
There was a problem hiding this comment.
This should prevent stripping of debug symbols while not in release mode. I'm guessing it will shave disk space, but more importantly, I wonder if there is some sort of performance penalty for not stripping the symbols.
| ] | ||
| doNotStrip '**/*.so' | ||
| // Should prevent clashes with other libraries that use OpenSSL | ||
| pickFirst '**/x86/libcrypto.so' |
There was a problem hiding this comment.
Should prevent conflicts when other libraries also generate libcrypto.so like flipper or op-sqlcipher
There was a problem hiding this comment.
Yea I mean it's kinda unsafe here but that's the developers fault if he includes two libs with different major versions imo.
There was a problem hiding this comment.
Transitive dependencies are a bitch
| { | ||
| "prefer_split_fsevents_watcher": true |
There was a problem hiding this comment.
Gets rid of the annoying re-crawled message when metro starts
There was a problem hiding this comment.
That always annoyed me, lol. I wonder why that bugs tho
There was a problem hiding this comment.
Tzvetan mentioned something about macos not being their default platform, so fsevents is kinda just duck-taped in
| @@ -27,7 +27,7 @@ protected List<ReactPackage> getPackages() { | |||
| List<ReactPackage> packages = new PackageList(this).getPackages(); | |||
| // Packages that cannot be autolinked yet can be added manually here, for example: | |||
| // packages.add(new MyReactNativePackage()); | |||
| packages.add(new QuickCryptoPackage()); | |||
| // packages.add(new QuickCryptoPackage()); | |||
There was a problem hiding this comment.
I don't remember why we did this, it seems we were not correctly linking the dependency. This is no longer necessary
| @@ -1,5 +1,6 @@ | |||
| const crypto = require('crypto'); | |||
| const quickCrypto = require('react-native-quick-crypto'); | |||
| // const quickCrypto = require('react-native-quick-crypto'); | |||
| import quickCrypto from 'react-native-quick-crypto'; | |||
There was a problem hiding this comment.
Needed so that metro correctly resolves the dependency now
| { | ||
| "prefer_split_fsevents_watcher": true |
There was a problem hiding this comment.
That always annoyed me, lol. I wonder why that bugs tho
| ] | ||
| doNotStrip '**/*.so' | ||
| // Should prevent clashes with other libraries that use OpenSSL | ||
| pickFirst '**/x86/libcrypto.so' |
There was a problem hiding this comment.
Yea I mean it's kinda unsafe here but that's the developers fault if he includes two libs with different major versions imo.
|
CI is failing unfortunately. I think we can fix that in a separate PR |
I could not build Android. I updated the package build files, configs, etc to a more recent configuration and now everything seems to be working.