Update release #445
Open
Update release #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add revenue share to rewards collector * fmt * remove v2.0 migration test * update types * improve pop_array methods * remove estimate exact out for reward amounts * improve tests for rewards collector * small tidy * safety fund and revenue share use same denom * fix integration test * update schema * generate types * update deploy scripts * make distribute method configurable * tidy comments * review comments * fix ibc integration test * update types and schema * enforce rc config cannot have fee_collector_denom the same as other denoms
… 2.1.0 -> 2.1.1) (#208) * add revenue share to rewards collector * fmt * remove v2.0 migration test * update types * improve pop_array methods * remove estimate exact out for reward amounts * improve tests for rewards collector * small tidy * safety fund and revenue share use same denom * fix integration test * update schema * generate types * update deploy scripts * make distribute method configurable * tidy comments * review comments * fix ibc integration test * update types and schema * enforce rc config cannot have fee_collector_denom the same as other denoms * add neutron migration * fix migration tests for neutron rc * migration for address provider * update schema * add osmosis RC migration * fix old migration test * fix old migration test * clear old state on migration * fmt
piobab
reviewed
Feb 20, 2025
| @@ -37,6 +37,10 @@ pub enum MarsAddressType { | |||
| Swapper, | |||
| /// Astroport incentives contract | |||
| AstroportIncentives, | |||
| /// Perps contract | |||
| Perps, | |||
piobab
approved these changes
Feb 21, 2025
| return Err(ContractError::SlippageLimitExceeded { | ||
| denom_in: asset_in_denom, | ||
| denom_out: asset_out_denom, | ||
| min_receive_minumum: min_receive_lower_limit, |
There was a problem hiding this comment.
typo min_receive_minumum
If we don't fix, there are 3 guys in the line waiting to fix it :D
| } | ||
|
|
||
| impl Config { | ||
| pub fn validate(&self) -> Result<(), ValidationError> { | ||
| decimal_param_le_one(self.safety_tax_rate, "safety_tax_rate")?; | ||
| let total_tax_rate = self.safety_tax_rate + self.revenue_share_tax_rate; | ||
| decimal_param_le_one(total_tax_rate, "total_tax_rate")?; |
There was a problem hiding this comment.
I just notice that would be nice to have validation if sum of the tax rates for 3 bucket is 100%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.