-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_std support #62
no_std support #62
Conversation
Thanks for this; I'll take a look. Unfortunately it will probably take me several weeks at least to get to this. I'm moving right now, so my spare time goes towards putting things in cardboard boxes. |
No hurries. Thanks for the headsup! |
This looks correct to me, I also tested it on no_std (but with alloc available) and it works as expected, thanks! |
In environments without an allocator, the API provides only the | ||
`encode_config_slice()` and `decode_config_slice()` functions (which | ||
do not use the dynamically-sized `Vec` type) and the | ||
`strip_whitespace` config must be disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unpleasant interplay of features is yet more evidence to me that line wrapping (and its dual, whitespace stripping) are a mistake to include, at least at this level. Maybe a base64::ext
should contain helper functions to do that stuff after the fact. This would also simplify #56.
Line wrapping is gone, and I'm going to remove whitespace stripping as well, which should make this tidier to implement. |
What's the status of this? |
I'd like to have this feature shipped; it's just waiting on my free time. Now that the If you feel like picking up the pieces from this long since bitrotted PR, that'd be great, but if not, it'll be several months likely until I can dedicate the time to do it myself. |
This is now done via #111. |
Could be useful for embedded systems.
Thank you for this project!