Fix PHP 8.4 deprecations nullable objects #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/php-84-deprecations
branch
from
c716335 to
89bdac6
Compare
alexander-schranz
force-pushed
the
enhancement/php-84-deprecations
branch
2 times, most recently
from
2b1f471 to
5cb7be0
Compare
composer.json
Outdated
| @@ -32,7 +32,7 @@ | |||
| "symfony/security-bundle": "^4.3 || ^5.0 || ^6.0 || ^7.0", | |||
| "symfony/twig-bundle": "^4.3 || ^5.0 || ^6.0 || ^7.0", | |||
| "symfony/validator": "^4.3 || ^5.0 || ^6.0 || ^7.0", | |||
| "symfony/phpunit-bridge": "^5.0.4 || ^6.0 || ^7.0", | |||
| "symfony/phpunit-bridge": "^5.0.4 || ^6.0 || 7.1.*", | |||
There was a problem hiding this comment.
The 7.2 bridge currently fails with: PHP Fatal error: Uncaught Error: Call to private PHPUnit\Framework\TestSuite::__construct() from scope PHPUnit\Util\Configuration in /home/runner/work/MassiveSearchBundle/MassiveSearchBundle/vendor/bin/.phpunit/phpunit-8-1/src/Util/Configuration.php:990
There was a problem hiding this comment.
Looks like this is failing since a longer time without a proper fix yet. So I will ignore the issue.
alexander-schranz
force-pushed
the
enhancement/php-84-deprecations
branch
from
5cb7be0 to
2f1441f
Compare
alexander-schranz
force-pushed
the
enhancement/php-84-deprecations
branch
from
2f1441f to
9687209
Compare
Prokyonn
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.