Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore functionality of upload-progress for HTTP2 #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restore functionality of upload-progress for HTTP2 #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ngx_http_uploadprogress_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,16 @@ static void ngx_http_uploadprogress_event_handler(ngx_http_request_t *r)
module_ctx = ngx_http_get_module_ctx(r, ngx_http_uploadprogress_module);
if (module_ctx != NULL ) {
module_ctx->read_event_handler(r);
/*
* Both ngx_http_v2_read_request_body() and
* ngx_http_v2_process_request_body() modify read_event_handler,
* we respect the change, but re-interpose our function so we still get
* future events, otherwise we miss all upload progress.
*/
if (r->read_event_handler != ngx_http_uploadprogress_event_handler) {
module_ctx->read_event_handler = r->read_event_handler;
r->read_event_handler = ngx_http_uploadprogress_event_handler;
}
}

/* at this stage, r is not anymore safe to use */
Expand Down