feat: ✨ improve icon review workflow #2689
Open
+83
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should now be 100% correct in finding changed files ↪ This commit was largely generated by AI (Copilot with OpenAI model o1).
Co-authored-by: Copilot <[email protected]> Signed-off-by: Okinea Dev <[email protected]>
Co-authored-by: Copilot <[email protected]>
okineadev
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
PKief
requested changes
Nov 9, 2024
There was a problem hiding this comment.
I just tested it on my fork and it's still not working 🙁 It's still using the SVG from the main branch and not from the fork. I've mentioned this before, but will post it here again, would you please follow the next steps to test this workflow on your end?
- Fork the repo vscode-material-icon-theme
- Copy and paste the changes from this PR to the main branch of the fork
- Create a new branch in the fork (with the changed workflow on main)
- Change some icons
- Commit and push changes
- Create a new PR of this branch in the fork which targets to main in the fork
- Let the workflows run
It's some manual work which can't be done by AI, but it's costing me some time to do it on every review. Please do this on your end to verify your changes, before asking me again for another review.
PKief
force-pushed
the
main
branch
2 times, most recently
from
7918c28
to
7cb05b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Guidelines