Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for amscd #1192

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Update tests for amscd #1192

merged 2 commits into from
Feb 27, 2025

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Feb 4, 2025

This PR updates the tests for the amscd package and its code.

Here, the if (a || b) on line 127 is always true due to lines 124 to 126 that set a when it is not set. The if is removed, and the block indentation is adjusted.

The change at line 204 is because the table and row arrays are always defined.

Again, viewing without white-space changes is useful, here.

@dpvc dpvc requested a review from zorkow February 4, 2025 18:58
@dpvc dpvc added this to the v4.0 milestone Feb 4, 2025
Base automatically changed from update-test-framework to develop February 25, 2025 20:55
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of the conditional in line 130 alttogether.

@dpvc dpvc requested a review from zorkow February 27, 2025 00:24
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 21351c7 into develop Feb 27, 2025
@dpvc dpvc deleted the test-amscd branch February 27, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants