Update tests for the newcommand package, and update code #1200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the test for the
newcommand
extension. In theNewcommandUtil.ts
, the case wherej < 0
does not occur, asj
is reduced only on line 213, and that is only whenhasBraces
is true. For that to be the case, there would have had to have been an initial open brace, in which case line 206 would have calledGetArgument()
, which would find a matching close brace, so there must be at least two characters (the two braces), andj
would be at least 2 before it is decremented. So it never gets below 0.