Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the setoptions package and fix code #1204

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Feb 4, 2025

This PR adds tests for the setoptions package, and updates its configuration file.

The changes to the configuration include:

  • Breaking the error message at 82-86 into two messages, one for the TeX options, and one for package options, mirroring the messages in (original) lines 91-103.
  • To do that, the isTexvariable is moved earlier to line 78.
  • The filterValue() function is extended to handle RegExp values (like the one for the ams parameter operatornamePattern).
  • The setoptions command map is now created within the setoptionsConfig() function. This means that the map will be recreated for each instance of the setoptions package, so if there are two TeX input jax created, one with [tex]/require includes and one without it, the first will get the updated \require macro that allows options, while the second will have the original \require. The original version would have shared the setoptions map between the two, so both would get the updated \require.

@dpvc dpvc requested a review from zorkow February 4, 2025 21:48
@dpvc dpvc added this to the v4.0 milestone Feb 4, 2025
Base automatically changed from update-test-framework to develop February 25, 2025 20:55
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 1321932 into develop Feb 26, 2025
@dpvc dpvc deleted the test-setoptions branch February 26, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants