Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Tests improvements: logs and mainnet edge cases #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucca30
Copy link
Contributor

@lucca30 lucca30 commented Feb 10, 2025

Description

Improvements on RPC tests to better log and better handle edge cases on mainnet.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewers or the whole pos-v1 team
  • I have added sufficient documentation in the code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

It should never be the case...

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to heimdall
    • In case link the PR here:

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy

@lucca30 lucca30 requested a review from a team February 10, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants