Engineered tests to always reproduce tricky remote invite -> join/reject scenarios #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvite scenario Regression tests for element-hq/synapse#18075
Merged
1 task
|
Closing as I'm doubtful that I'll get a chance to move forward 😬 This is a good idea to address if anyone else is keen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawning from @kegsay's comment to improve the remote invite -> join/reject tests;
Previously, we only had end-to-end tests with two real homeservers (#757), but we can control the scenario conditions completely if we use a fake Complement homeserver. This PR adds some "engineered" variants of the tests to always reproduce tricky invite scenario.
Regression tests for element-hq/synapse#18075
Follow-up to #757
Pull Request Checklist