Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-7066 (code background redundancy) #7446

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

chessmadridista
Copy link

@chessmadridista chessmadridista commented Oct 7, 2024

Summary

Code redundancy issues have been resolved for prepare-mattermost-database.rst. Issues for other files will be submitted in separate PRs. Once all the files have been modified, the main issue will be marked as completed and closed.

The redundant background was removed by removing an extra indentation in the code blocks. The redundant background can be removed in other files following the same approach.

Ticket Link

#7066

Note: There are multiple files that need to be taken care of in this issue. Please do not mark this issue as closed.

@mattermost-build
Copy link
Contributor

Hello @chessmadridista,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm self-requested a review October 9, 2024 13:28
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Newest code from chessmadridista has been published to preview environment for Git SHA 42d0a49

@cwarnermm
Copy link
Member

@chessmadridista - I very much appreciate your patience on a review of this PR.

"The redundant background was removed by removing an extra indentation in the code blocks. The redundant background can be removed in other files following the same approach."

The extra indentation in the code blocks is intentional and should not be modified. Adjusting indentation isn't a viable way to address the redundant background display issue.

By default, the Sphinx theme (Furo) being used adds a background colour to code blocks. Additional CSS is being applied on top resulting in the redundant background issue.

@chessmadridista
Copy link
Author

chessmadridista commented Oct 9, 2024

@chessmadridista - I very much appreciate your patience on a review of this PR.

"The redundant background was removed by removing an extra indentation in the code blocks. The redundant background can be removed in other files following the same approach."

The extra indentation in the code blocks is intentional and should not be modified. Adjusting indentation isn't a viable way to address the redundant background display issue.

By default, the Sphinx theme (Furo) being used adds a background colour to code blocks. Additional CSS is being applied on top resulting in the redundant background issue.

@cwarnermm Thank you for the feedback! I'll look into it and will make the necessary changes.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@cwarnermm cwarnermm removed the Hacktoberfest null label Nov 1, 2024
@cwarnermm
Copy link
Member

@chessmadridista - Are you actively working on this issue?

@chessmadridista
Copy link
Author

Not at the moment. I plan to take it up after 2-3 weeks if nobody else picks this up. Apologies for not intimating you about the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Editor Review Requires review by an editor Contributor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants