Hook up sound from jsbeeb #117
Conversation
|
I've marked this as a draft because the error needs fixing, but I'm not really a JS dev and I'm stumped as to how to debug it - I don't see anything in the browser's JS console. @mattgodbolt Any ideas? The styling of the "audio-warning" probably needs sorting out too, but that's only cosmetic at least. |
|
I'll have a poke about at the weekend! Thanks for taking a look |
|
Probably worth a chat with @8bitkick as to whether no sound was a very deliberate choice too |
|
Any thoughts, Dom? FWIW I doubt it was deliberate - even just thinking about writing code for BBCMicrobot, the bot used to support sound and that code is still there if you select jsbeeb as the emulator to use, but sound has not yet been implemented when using beebjit as the emulator, which is the hard-wired default. The main obstacle there is lack of support for recording audio from a headless beebjit - I did try to implement that but the patch had some problems that I probably needed help to resolve and sadly I never got any response: scarybeasts/beebjit#48 |
|
Another data point - 8bitkick's old editor supported sound from the emulator. |
This patch does get us working sound, but during loading a modal full-window error pops up: Uncaught runtime errors: ERROR The operation was aborted. Clicking the X in the top right continues to a working owlet. I've failed to work out where this is coming from. Fixes mattgodbolt#80
@mattgodbolt Did you get anywhere poking this? I had another poke myself, commenting out various things and monkey patching stub functions over things and even adding (I've also rebased onto current main to make sure this wasn't caused by something we'd already fixed recently - if that's unhelpful feel free to |
|
I'm sorry @ojwb I did not in fact look... I'll try and take a look next week (this week is a write-off). Sorry! |
|
I'm still failing on this: it has progressed to "sticky note on my monitor" priority, but in fair warnings I've been prepping an important talk for next week...after that things get a little free-er |
This patch does get us working sound, but during loading a modal full-window error pops up:
Uncaught runtime errors:
ERROR
The operation was aborted.
Clicking the X in the top right continues to a working owlet. I've failed to work out where this is coming from.
Fixes #80