This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
add doc for https://github.com/mautic/mautic/pull/8196 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npracht
added
Pending PR Merging
This was referenced Nov 9, 2021
fakela
reviewed
Nov 9, 2021
|
Looks great 👍, thank you @npracht I just left a small suggestion. |
|
@RCheesley please review |
RCheesley
suggested changes
Nov 10, 2021
There was a problem hiding this comment.
Hey folks!
I know those link macros are not part of this PR but they are all invalid and will result in broken links.
Release links should be to the tag for the release:
https://github.com/mautic/mautic/releases/tag/number
Can we please fix it while we are here?
Also added a correction for capitalising the names of features in Mautic per the styleguide.
| @@ -57,6 +57,8 @@ As of [Mautic 2.10.0][release-2.10.0] you are now able to match form fields with | |||
|
|
|||
| As of [Mautic 2.2.0][release-2.2.0], for fields that include select lists (select, radio, checkboxes), options can be synced with the contact field itself. No more having to manually keep them in sync! If a custom field's list is updated, simply rebuild the form's HTML. | |||
|
|
|||
| As of [Mautic 4.1.0][release-4.1.0], you can decide to skip saving the value if you already have a value for the contact or company field. This might help you avoid erasing an existing value you wouldn't like to lose. | |||
There was a problem hiding this comment.
Suggested change
| As of [Mautic 4.1.0][release-4.1.0], you can decide to skip saving the value if you already have a value for the contact or company field. This might help you avoid erasing an existing value you wouldn't like to lose. | |
| As of [Mautic 4.1.0][release-4.1.0], you can decide to skip saving the value if you already have a value for the Contact or Company field. This might help you avoid erasing an existing value you wouldn't like to lose. |
| @@ -134,3 +136,4 @@ So, what happened is `{pagelink=1}` was converted into the landing page URL and | |||
| [release-2.3.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.3.0> | |||
| [release-2.10.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.10.0> | |||
| [release-2.15.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.15.0> | |||
| [release-4.1.0]: <../../../../index.php.com/mautic/mautic/releases/tag/4.1.0> | |||
There was a problem hiding this comment.
Suggested change
| [release-4.1.0]: <../../../../index.php.com/mautic/mautic/releases/tag/4.1.0> | |
| [release-4.1.0]: <https://github.com/mautic/mautic/releases/tag/4.1.0> |
| @@ -134,3 +136,4 @@ So, what happened is `{pagelink=1}` was converted into the landing page URL and | |||
| [release-2.3.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.3.0> | |||
| [release-2.10.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.10.0> | |||
| [release-2.15.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.15.0> | |||
There was a problem hiding this comment.
Suggested change
| [release-2.15.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.15.0> | |
| [release-2.15.0]: <https://github.com/mautic/mautic/releases/tag/2.15.0> |
| @@ -134,3 +136,4 @@ So, what happened is `{pagelink=1}` was converted into the landing page URL and | |||
| [release-2.3.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.3.0> | |||
| [release-2.10.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.10.0> | |||
There was a problem hiding this comment.
Suggested change
| [release-2.10.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.10.0> | |
| [release-2.10.0]: <https://github.com/mautic/mautic/releases/tag/2.10.0> |
| @@ -134,3 +136,4 @@ So, what happened is `{pagelink=1}` was converted into the landing page URL and | |||
| [release-2.3.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.3.0> | |||
There was a problem hiding this comment.
Suggested change
| [release-2.3.0]: <../../../../index.php.com/mautic/mautic/releases/tag/2.3.0> | |
| [release-2.3.0]: <https://github.com/mautic/mautic/releases/tag/2.3.0> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #253