Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preference to set default_period #1941

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Preference to set default_period #1941

wants to merge 1 commit into from
+18 −5

Conversation

nikhilbadyal
Copy link
Contributor

No description provided.

@nikhilbadyal nikhilbadyal marked this pull request as draft March 2, 2025 05:34
@nikhilbadyal nikhilbadyal force-pushed the nikhil/default-preference branch 3 times, most recently from da88c7d to 681b402 Compare March 2, 2025 15:30
@nikhilbadyal
Copy link
Contributor Author

@zachgoll any opinion on this ?

zachgoll
zachgoll reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@zachgoll zachgoll left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just a couple quick thoughts off the top of my head:

  • For the preference, we should set this at the User level as different users within the same family might want to see different default views
  • We should avoid passing family into any of the Period methods to avoid mixing responsibilities. I'm thinking in the controller, we should just explicitly pass in Period.from_key(params[:period] || family.default_period)
  • Sparklines should always use the default period and not be configurable as those are purely to see a trend of the account recently

@zachgoll zachgoll mentioned this pull request Mar 3, 2025
Closed
@nikhilbadyal nikhilbadyal force-pushed the nikhil/default-preference branch 3 times, most recently from 42e26ce to 19d85fb Compare March 3, 2025 19:00
@nikhilbadyal nikhilbadyal force-pushed the nikhil/default-preference branch from 19d85fb to e63a8ad Compare March 3, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgoll zachgoll zachgoll left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhilbadyal @zachgoll