Add Embark theme #533
Merged
Add Embark theme #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxWarning: invalid escape sequence '\.' Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
This was done in mbadolato#526, however, we should update the root iTerm2 theme, not a specific terminal theme. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
I don't know how these have been missed. They're generated simply by running: python tools/gen.py Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the Embark theme from https://embark-theme.github.io/.
While adding this, I noted that we were missing a few screenshots and some variants of themes for various editors. These are all addressed in separate commits. I suggest looking at the commits tab where reviewing these.
I have no updated
CREDITS.mdsince I did not author this theme.Theme Submission Checklist
README.mdwith new theme and screenshotCREDITS.mdwith new themetools/gen.pyto generate themes in all formatsscreenshots/README.mdwith new theme