-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Prepare docs for refactoring #678
base: poc/vizro_ai_charts_refactor
Are you sure you want to change the base?
Conversation
@@ -37,7 +37,7 @@ This guide explains the different ways in which you can add a chart generated by | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadijagraca Could you maybe exchange the gif 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments left for readability but nothing else.
Did you look at https://github.com/McK-Internal/vizro-internal/issues/1173 and have you covered any of the comments you raised previously about docs structure with this PR? If so, please feel free to close it!
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, dashboard is not compatible with other vendors yet. Otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I didn't have trouble following the instructions and replicating the examples. ⭐
43a45ff
to
f94fe52
Compare
Description
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":