Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): add missing useEffect deps for journey #1230

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

anupcowkur
Copy link
Contributor

Description

  • Adds missing useEffect deps for journey
  • Removes loading state for visual improvement

Related issue

Fixes #1227

@anupcowkur anupcowkur requested a review from detj September 11, 2024 10:46
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
measure-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 10:48am

fixes #1227

also removes loading state for visual improvement
@anupcowkur anupcowkur merged commit 743811b into main Sep 11, 2024
6 checks passed
@anupcowkur anupcowkur deleted the fix-exception-details-journey-filters branch September 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash & ANR detail journeys not being updated on filter changes
2 participants