Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): validate required event & span attributes #1590

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

detj
Copy link
Contributor

@detj detj commented Dec 10, 2024

Summary

Validate all required event & span attributes before ingestion.

Tasks

  • Refactor attribute.platform validation to be consistent between event and span attributes.
  • Validate attribute.installation_id
  • Validate attribute.measure_sdk_version
  • Validate attribute.app_version
  • Validate attribute.app_build
  • Validate attribute.app_unique_id

See also

@detj detj added bug something isn't working backend backend related labels Dec 10, 2024
@detj detj requested a review from abhaysood December 10, 2024 17:11
@detj detj self-assigned this Dec 10, 2024
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
measure-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:11pm

@detj detj merged commit fb57461 into main Dec 11, 2024
8 checks passed
@detj detj deleted the event-span-validation branch December 11, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend backend related bug something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Validate required event and span attributes
2 participants