Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add memory usage absolute plot in session timeline #1625

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat(frontend): add memory usage absolute plot in session timeline #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion frontend/dashboard/app/api/api_calls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,14 @@ export const emptySessionReplay = {
"timestamp": ""
}
],
"memory_usage_absolute": [
{
"max_memory": 0,
"used_memory": 0,
"interval": 0,
"timestamp": ""
}
],
"session_id": "",
"threads": {
"main": [
Expand Down Expand Up @@ -1622,4 +1630,4 @@ export const fetchUsageFromServer = async (teamId: string, router: AppRouterInst
} catch {
return { status: FetchUsageApiStatus.Cancelled, data: null }
}
}
}
84 changes: 80 additions & 4 deletions frontend/dashboard/app/components/session_replay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,27 @@ const SessionReplay: React.FC<SessionReplayProps> = ({ teamId, appId, sessionRep
}
] : null

const memoryAbsData = sessionReplay.memory_usage_absolute != null ? [
{
id: 'Max Memory',
data: sessionReplay.memory_usage_absolute
.filter(item => isWithinEventTimeRange(item.timestamp))
.map(item => ({
x: formatTimestampToChartFormat(item.timestamp),
y: item.max_memory
}))
},
{
id: 'Used Memory',
data: sessionReplay.memory_usage_absolute
.filter(item => isWithinEventTimeRange(item.timestamp))
.map(item => ({
x: formatTimestampToChartFormat(item.timestamp),
y: item.used_memory
}))
},
] : null

const seekBarIndicatorOffset = 90
const [seekBarValue, setSeekBarValue] = useState(0)
const eventRefs = useRef<(HTMLDivElement | null)[]>([])
Expand Down Expand Up @@ -242,7 +263,7 @@ const SessionReplay: React.FC<SessionReplayProps> = ({ teamId, appId, sessionRep
return (
<div className="flex flex-col w-[1100px] font-sans text-black">
{/* Graphs container */}
{(cpuData != null || memoryData != null) &&
{(cpuData != null || memoryData != null || memoryAbsData != null) &&
<div className="relative"
ref={graphContainerRef}
>
Expand Down Expand Up @@ -281,7 +302,62 @@ const SessionReplay: React.FC<SessionReplayProps> = ({ teamId, appId, sessionRep
tickSize: 1,
tickPadding: 5,
tickValues: 5,
legend: 'Memory in MB',
legend: 'Memory in KB',
legendOffset: -80,
legendPosition: 'middle'
}}
colors={{ scheme: 'nivo' }}
tooltip={({ point }) => {
return (
<div className='bg-neutral-950 text-white flex flex-row items-center p-2 text-xs'>
<div className="w-2 h-2 rounded-full" style={{ backgroundColor: point.serieColor }} />
<div className="flex flex-col items-left px-4 py-1" key={point.id}>
<p>Time: {formatChartFormatTimestampToHumanReadable(point.data.xFormatted.toString())}</p>
<div className="py-0.5" />
<p>{point.serieId}: {point.data.y.toString()} KB</p>
</div>
</div>
)
}}
/>
</div>
}
{/* Memory Absolute line */}
{memoryAbsData != null &&
<div className="select-none">
<LineCanvas
width={1100}
height={200}
data={memoryAbsData}
curve="monotoneX"
crosshairType="cross"
margin={{ top: 40, right: 0, bottom: 80, left: 90 }}
xFormat='time:%Y-%m-%d %H:%M:%S:%L %p'
xScale={{
format: '%Y-%m-%d %I:%M:%S:%L %p',
precision: 'second',
type: 'time',
min: DateTime.fromISO(events[0].timestamp).toLocal().toJSDate(),
max: DateTime.fromISO(events[events.length - 1].timestamp).toLocal().toJSDate(),
useUTC: false
}}
yScale={{
type: 'linear',
min: 0,
max: 'auto'
}}
axisTop={null}
axisRight={null}
axisBottom={{
format: '%-I:%M:%S %p',
legendPosition: 'middle',
tickRotation: 45
}}
axisLeft={{
tickSize: 1,
tickPadding: 5,
tickValues: 5,
legend: 'Memory in KB',
legendOffset: -80,
legendPosition: 'middle'
}}
Expand All @@ -293,7 +369,7 @@ const SessionReplay: React.FC<SessionReplayProps> = ({ teamId, appId, sessionRep
<div className="flex flex-col items-left px-4 py-1" key={point.id}>
<p>Time: {formatChartFormatTimestampToHumanReadable(point.data.xFormatted.toString())}</p>
<div className="py-0.5" />
<p>{point.serieId}: {point.data.y.toString()} MB</p>
<p>{point.serieId}: {point.data.y.toString()} KB</p>
</div>
</div>
)
Expand Down Expand Up @@ -400,4 +476,4 @@ const SessionReplay: React.FC<SessionReplayProps> = ({ teamId, appId, sessionRep
)
}

export default SessionReplay
export default SessionReplay
Loading