fix(backend): support no app version filters #1732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify GET `/apps/:id/metrics` API to support no app versions - Modify GET `/apps/:id/journey` API to support no app versions - Modify GET `/apps/:id/crashGroups` API to support no app versions - Modify GET `/apps/:id/crashGroups/plots/instances` API to support no app versions - Modify GET `/apps/:id/crashGroups/:crashGroupId/crashes` API to support no app versions - Modify GET `/apps/:id/crashGroups/:crashGroupId/plots/instances` API to support no app versions - Modify GET `/apps/:id/crashGroups/:crashGroupId/plots/distribution` API to support no app versions - Modify GET `/apps/:id/anrGroups` API to support no app versions - Modify GET `/apps/:id/anrGroups/plots/instances` API to support no app versions - Modify GET `/apps/:id/anrGroups/:anrGroupId/anrs` API to support no app versions - Modify GET `/apps/:id/anrGroups/:anrGroupId/plots/instances` API to support no app versions - Modify GET `/apps/:id/anrGroups/:anrGroupId/plots/distribution` API to support no app versions fixes #1725 Signed-off-by: detj <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Modify GET `/apps/:id/sessions` API to support no app versions Signed-off-by: detj <[email protected]>
|
Closing this PR as we won't support "none" option in app version selector, while other selectors will gain "none" support separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all relevant dashboard APIs to return empty response when requested with no app versions. This allows us to implement a "Clear all" filter option on the dashboard.
Tasks
/apps/:id/metricsAPI to support no app versions/apps/:id/journeyAPI to support no app versions/apps/:id/crashGroupsAPI to support no app versions/apps/:id/crashGroups/plots/instancesAPI to support no app versions/apps/:id/crashGroups/:crashGroupId/crashesAPI to support no app versions/apps/:id/crashGroups/:crashGroupId/plots/instancesAPI to support no app versions/apps/:id/crashGroups/:crashGroupId/plots/distributionAPI to support no app versions/apps/:id/anrGroupsAPI to support no app versions/apps/:id/anrGroups/plots/instancesAPI to support no app versions/apps/:id/anrGroups/:anrGroupId/anrsAPI to support no app versions/apps/:id/anrGroups/:anrGroupId/plots/instancesAPI to support no app versions/apps/:id/anrGroups/:anrGroupId/plots/distributionAPI to support no app versions/apps/:id/sessionsAPI/apps/:id/sessions/plots/instancesAPI/apps/:id/sessions/:sessionIdAPI/apps/:id/spans/roots/namesAPI/apps/:id/spans/instancesAPI/apps/:id/spans/plotAPISee also